Download external resources preference

Signed-off-by: azerr <azerr@redhat.com>

Author: angelozerr

README.md

@@ -83,6 +83,7 @@ The following settings are supported:
 * `xml.trace.server`: Trace the communication between VS Code and the XML language server in the Output view. Default is `off`.
 * `xml.logs.client`: Enable/disable logging to the Output view. Default is `true`.
 * [`xml.catalogs`](https://github.com/redhat-developer/vscode-xml/blob/master/docs/Preferences.md#catalogs): Register XML catalog files.
+* `xml.downloadExternalResources.enabled`: Download external resources like referenced DTD, XSD. Default is `true`.
 * [`xml.fileAssociations`](https://github.com/redhat-developer/vscode-xml/blob/master/docs/Preferences.md#file-associations): Allows XML schemas/ DTD to be associated to file name patterns.
 * [`xml.format.enabled`](https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatenabled): Enable/disable ability to format document. Default is `true`.
 * [`xml.format.emptyElements`](https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatemptyelements): Expand/collapse empty elements. Default is `ignore`.

package.json

@@ -177,6 +177,12 @@
           "default": true,
           "markdownDescription": "Enable/disable logging to the Output view. Default is `true`."
         },
+        "xml.downloadExternalResources.enabled": {
+          "type": "boolean",
+          "default": true,
+          "markdownDescription": "Download external resources like referenced DTD, XSD. Default is `true`.",
+          "scope": "window"
+        },
         "xml.catalogs": {
           "type": "array",
           "default": [],
@@ -320,16 +326,6 @@
           "default": false,
           "markdownDescription": "The option to put a closing bracket on a newline when `#xml.format.splitAttributes#` is `true`. Default value is `false`. See [here](command:xml.open.docs?%5B%7B%22page%22%3A%22Formatting%22%2C%22section%22%3A%22xmlformatclosingbracketnewline%22%7D%5D) for more information."
         },
-        "xml.preferences.quoteStyle": {
-          "type": "string",
-          "enum": [
-            "single",
-            "double"
-          ],
-          "default": "double",
-          "markdownDescription": "Preferred quote style to use for completion: `single` quotes, `double` quotes. Default is `double`.",
-          "scope": "window"
-        },
         "xml.completion.autoCloseTags": {
           "type": "boolean",
           "default": true,
@@ -347,6 +343,16 @@
           "default": false,
           "markdownDescription": "Enable/disable XML CodeLens. Default is `false`. See [here](command:xml.open.docs?%5B%7B%22page%22%3A%22CodeLens%22%2C%22section%22%3A%22Code%20Lens%22%7D%5D) for information about CodeLens features"
         },
+        "xml.preferences.quoteStyle": {
+          "type": "string",
+          "enum": [
+            "single",
+            "double"
+          ],
+          "default": "double",
+          "markdownDescription": "Preferred quote style to use for completion: `single` quotes, `double` quotes. Default is `double`.",
+          "scope": "window"
+        },
         "xml.preferences.showSchemaDocumentationType": {
           "type": "string",
           "default": "all",

src/settings/settings.ts

@@ -225,9 +225,11 @@ export function getXMLSettings(javaHome: string | undefined, logfile: string, ex
   // Check workspace trust
   const isWorkspaceTrusted = (workspace as any).isTrusted;
   if (isWorkspaceTrusted !== undefined && !isWorkspaceTrusted) {
-    xml['xml']['validation']['resolveExternalEntities'] = false;
+    xml['xml']['validation']['resolveExternalEntities']['enabled'] = false;
+    xml['xml']['downloadExternalResources'] = false;
   } else {
     xml['xml']['validation']['resolveExternalEntities'] = workspace.getConfiguration('xml').get('validation.resolveExternalEntities', false);
+    xml['xml']['downloadExternalResources']['enabled'] = workspace.getConfiguration('xml').get('downloadExternalResources.enabled', false);
   }
 
   //applying externalXmlSettings to the xmlSettings