Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2649: Add support for choosing search scope #3748

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

gayanper
Copy link
Contributor

@gayanper gayanper commented Aug 24, 2024

Provide two scopes to search from for search operations such as

  • reference search
  • call hierarchy search

Fixes #2649

@gayanper
Copy link
Contributor Author

Adds the following status bar item to toggle and see the current scope in use

image

Clicking on the status bar item or triggering from command pallet will provide the following scope picker list

image

The command in the command pallet
image

@rgrunber rgrunber added this to the End September 2024 milestone Aug 28, 2024
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial comments. The main one being I'd prefer to place the command under the server status bar with the other shortcuts rather than having its own status bar item at the bottom.

We need to be careful not to have too many.

package.json Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@gayanper
Copy link
Contributor Author

gayanper commented Sep 7, 2024

Other the name 'main' and 'test' for scopes, I applies all other suggestions since I also agree with those suggestion considering how we want to features to expressed in extension.

Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is ready to be merged once we figure out the LS situation.

src/extension.ts Show resolved Hide resolved
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the README.md, can you add a section (at the bottom of settings) listing the new setting for the upcoming 1.35.0 ? See bf05afb#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R252 for an example. You can reuse the markdownDescription from your setting.

package.json Outdated Show resolved Hide resolved
@gayanper
Copy link
Contributor Author

I will add during today @rgrunber

@rgrunber rgrunber removed this from the End September 2024 milestone Sep 24, 2024
@rgrunber rgrunber mentioned this pull request Sep 25, 2024
Provide two scopes to search from for search operations such as
- reference search
- call hierarchy search

Signed-off-by: Gayan Perera <gayanper@gmail.com>
- move scope switching to java status.
- move the setting to code navigation category.

Signed-off-by: Gayan Perera <gayanper@gmail.com>
Signed-off-by: Gayan Perera <gayanper@gmail.com>
@gayanper
Copy link
Contributor Author

Under the README.md, can you add a section (at the bottom of settings) listing the new setting for the upcoming 1.35.0 ? See bf05afb#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R252 for an example. You can reuse the markdownDescription from your setting.

@rgrunber Done

Signed-off-by: Gayan Perera <gayanper@gmail.com>
@rgrunber rgrunber merged commit 50d5bf5 into redhat-developer:master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for predefined workingsets for search operations
2 participants