-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2649: Add support for choosing search scope #3748
Fix #2649: Add support for choosing search scope #3748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial comments. The main one being I'd prefer to place the command under the server status bar with the other shortcuts rather than having its own status bar item at the bottom.
We need to be careful not to have too many.
Other the name 'main' and 'test' for scopes, I applies all other suggestions since I also agree with those suggestion considering how we want to features to expressed in extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is ready to be merged once we figure out the LS situation.
30c3db9
to
c681064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the README.md, can you add a section (at the bottom of settings) listing the new setting for the upcoming 1.35.0 ? See bf05afb#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R252 for an example. You can reuse the markdownDescription
from your setting.
I will add during today @rgrunber |
Provide two scopes to search from for search operations such as - reference search - call hierarchy search Signed-off-by: Gayan Perera <gayanper@gmail.com>
- move scope switching to java status. - move the setting to code navigation category. Signed-off-by: Gayan Perera <gayanper@gmail.com>
Signed-off-by: Gayan Perera <gayanper@gmail.com>
c681064
to
49f22ba
Compare
@rgrunber Done |
49f22ba
to
b0dd2da
Compare
Signed-off-by: Gayan Perera <gayanper@gmail.com>
b0dd2da
to
ea7863e
Compare
Provide two scopes to search from for search operations such as
Fixes #2649