refactor: moving list enterprise clusters to util package #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakis
force-pushed
the
refactor-list-enterprise-clusters
branch
from
fb7f2d3 to
c8e5796
Compare
| kafkamgmtclient "github.com/redhat-developer/app-services-sdk-core/app-services-sdk-go/kafkamgmt/apiv1/client" | ||
| ) | ||
|
|
||
| func ListEnterpriseClusters(f *factory.Factory) (*kafkamgmtclient.EnterpriseClusterList, error) { |
There was a problem hiding this comment.
shared utils is a place where methods defined are used in different subcommands. For example - kafkautil.InteractiveSelect is used in kafka, connectors and cluster subcommands.
ListEnterpriseClusters is used just in dedicated list, will it make sense to move it to pkg/cmd/dedicated/dedicatedcmdutil/dedicated_util.go?
There was a problem hiding this comment.
it will also be used in the create kafka cmd too, so that's the reason I moved it to shared
jackdelahunt
reviewed
Mar 1, 2023
| return nil, err | ||
| } | ||
| if len(clist.Items) == 0 { | ||
| return nil, f.Localizer.MustLocalizeError("dedicated.list.cmd.errorNoRegisteredClusters") |
There was a problem hiding this comment.
This should be a normal case we handle instead of returning an error
dimakis
force-pushed
the
refactor-list-enterprise-clusters
branch
from
c8e5796 to
b8e6058
Compare
dimakis
force-pushed
the
refactor-list-enterprise-clusters
branch
from
b8e6058 to
930a1d4
Compare
rkpattnaik780
approved these changes
Mar 1, 2023
jackdelahunt
pushed a commit
that referenced
this pull request
Mar 10, 2023
dimakis
added a commit
that referenced
this pull request
Mar 14, 2023
* feat: add machine pool logic * chore(vendor): update vendoring (#1798) * chore(vendor): update vendoring * feat: add cluster id to create kafka * fix(dedicated): attempts to correctly parse the cluster ingress dns name (#1806) This is so that "apps." prefix is always included and required by KFM when it is running under certain configuration Related to bf2fc6cc711aee1a0c2a/kas-installer#266 (comment) * refactor: refactor ocm methods out of register cmd * fix: pass no params during the installation of managed kafka addon (#1815) 👍 * feat: addition of the new list cluster cmd (#1817) * feat: addition of the new list cluster cmd * refactor: now querying ocm for clusters by id, remove flags as kfm doesn't support pagination * test: add some tests and fix ocm call string * feat: now listing customer cloud in rhoas kafka list (#1816) * refactor: dedicated changes now use new SDK * refactor: moving list enterprise clusters to util package (#1818) * feat: added name of cluster to kafka list (#1825) * feat: added name of cluster to kafka list * feat: clustermgmt url and access token flag to kafka list * chore: localized kafka list customer cloud * feat: kafka create with dedicated --------- Co-authored-by: Jack Delahunt <45426048+jackdelahunt@users.noreply.github.com> --------- Co-authored-by: Dimitri Saridakis <dimitri.saridakis@gmail.com> * feat: added de-register command --------- Co-authored-by: Dimitri Saridakis <dimitri.saridakis@gmail.com> Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com> * fix: now checking if reponse is empty in dedicated list * fix: now checking if reponse is empty in deregister * fix: correct output for deregister * feat: add clustermgmt flag to create kafka * chore: format & docs * chore: fix lint errors * refactor: hide flags, improves logic around passing cluster flag in register-cluster (#1836) --------- Co-authored-by: Dimitri Saridakis <dimitri.saridakis@gmail.com> Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com> Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this out for easy resuse
Closes #
Verification Steps
Type of change