platform/x86: hp-wmi: Fix error value for hp_wmi_tablet_state

Carlo Caione · dvhart · commit c7dfc2facbd6 · 2017-04-14T08:26:34.000-07:00
hp_wmi_tablet_state() fails to return the correct error code when
hp_wmi_perform_query() returns the HP WMI query specific error code
that is a positive value.

Signed-off-by: Carlo Caione &lt;carlo@endlessm.com&gt;
Signed-off-by: Darren Hart (VMware) &lt;dvhart@infradead.org&gt;
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
@@ -290,7 +290,7 @@ static int hp_wmi_tablet_state(void)
 	int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,
 				       sizeof(state), sizeof(state));
 	if (ret)
-		return ret;
+		return -EINVAL;
 
 	return (state & 0x4) ? 1 : 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ static int hp_wmi_tablet_state(void)`
`290`	`290`	`int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,`
`291`	`291`	`sizeof(state), sizeof(state));`
`292`	`292`	`if (ret)`
`293`		`- return ret;`
	`293`	`+ return -EINVAL;`
`294`	`294`
`295`	`295`	`return (state & 0x4) ? 1 : 0;`
`296`	`296`	`}`