Refined server error handling #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exising error handler is for listen and the first accept. After error handler is called, the server no longer accept. If user needs to re-accept, call listen(). There is no change from the original behavior. The new callback is added that takes ioc_context reference parameter. It can help io_context management when user uses ioc_con_getter. The error handler stop accept. But TLS/WS has aditionall errors. For example, timeout after TCP connection has been established. In this case, just accepted connection is error. And then continue new accepting sequence. User shouldn't call listen() in this case. In order to disstinguish this error, connect_error_handler is added.
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
- Coverage 83.32% 83.07% -0.26%
==========================================
Files 66 66
Lines 10323 10387 +64
==========================================
+ Hits 8602 8629 +27
- Misses 1721 1758 +37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.