Fix session present empty segv #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CONNACK is received, and previous session exists but stored message is empty, send_store_message() is called. Due to empty stored message, the callback was called immediately. It caused use heap after free error of coroutne. I don't know the detail mechanisim but post the callback call sovled the problem.
redboltz
force-pushed
the
fix_session_present_empty_segv
branch
from
323893c to
14601a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 83.51% 83.52%
=======================================
Files 62 62
Lines 9502 9506 +4
=======================================
+ Hits 7936 7940 +4
Misses 1566 1566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.