Skip to content

Add wildcard handling to topics in the test broker #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add wildcard handling to topics in the test broker #671

merged 1 commit into from
Oct 6, 2020

Conversation

jonesmz
Copy link
Contributor

@jonesmz jonesmz commented Oct 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #671 into master will increase coverage by 14.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #671       +/-   ##
===========================================
+ Coverage   68.59%   82.69%   +14.09%     
===========================================
  Files          44       46        +2     
  Lines        5935     7077     +1142     
===========================================
+ Hits         4071     5852     +1781     
+ Misses       1864     1225      -639     

@redboltz
Copy link
Owner

redboltz commented Oct 5, 2020

Is this refined version of #558 ?
Can I close #558 after #671 merged ?

@jonesmz
Copy link
Contributor Author

jonesmz commented Oct 5, 2020

@redboltz No, #558 is a better approach, but not finished.

@redboltz
Copy link
Owner

redboltz commented Oct 6, 2020

Should I merge #671 ? Doesn't #671 disturb #558 ?

@jonesmz
Copy link
Contributor Author

jonesmz commented Oct 6, 2020

This PR will make #558 have merge conflicts, but I don't believe that this PR will make implementing #558 any more complicated.

#558 uses the "Trie" datastructure to handle mqtt subscriptions, which is substantially better than boost-multi-index. This PR will not change how #558 is implemented, so any merge conflicts are not a big problem.

@jonesmz
Copy link
Contributor Author

jonesmz commented Oct 6, 2020

The reason for this PR is to allow wildcard handling right now, until #558 is finished.

@redboltz
Copy link
Owner

redboltz commented Oct 6, 2020

I understand. Thank you for elaborating.

@redboltz redboltz merged commit 873b2af into redboltz:master Oct 6, 2020
@jonesmz jonesmz deleted the subscription-wildcards branch October 6, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants