test_bucket_policy_elements_NotAction fails because correct expectations are not kept for effect=Allow

[mashetty330]

We expect the delete operation to fail at:

        if effect == "Allow":
            # Put Object is allowed
            logger.info("Writing index data to the bucket")
            assert s3_put_object(
                s3_obj=obc_obj,
                bucketname=obc_obj.bucket_name,
                object_key="index.html",
                data=index,
                content_type="text/html",
            ), "Failed to put object."

            # Delete bucket get access denied.
            logger.info(f"Deleting bucket {obc_obj.bucket_name}")
            try:
                s3_delete_bucket_website(s3_obj=obc_obj, bucketname=obc_obj.bucket_name)
                raise UnexpectedBehaviour(
                    "Failed: Bucket got deleted, expect to get AccessDenied."
                )

This expectation doesnt seem to be correct as per my understanding of the NotAction. NotAction parameters will exclude the action from the effect. So in this case, by default bucket can be deleted. By excluding DeleteBucket from the action list with effect=Allow doesnt make it to have deny affect!

This needs more analysis.

[DanielOsypenko]

reproduces with ROSA HCP https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/41837/consoleText
Also, the test is marked tier1 and was running as a tier1. But in the spreadsheet, it is a tier4b test which is odd. Please pay attention when fixing it.

@udaysk23

[Shilpi-Das1]

The test case fails for IBM Power 4.17.0-124 build as well

            # Delete bucket get access denied.
            logger.info(f"Deleting bucket {obc_obj.bucket_name}")
            try:
                s3_delete_bucket_website(s3_obj=obc_obj, bucketname=obc_obj.bucket_name)
>               raise UnexpectedBehaviour(
                    "Failed: Bucket got deleted, expect to get AccessDenied."
                )
E               ocs_ci.ocs.exceptions.UnexpectedBehaviour: Failed: Bucket got deleted, expect to get AccessDenied.

tests/functional/object/mcg/test_bucket_policy.py:982: UnexpectedBehaviour