RGW tests are not skipped in certain post-upgrade AWS deployments

[sagihirshfeld]

The logic in rgw/conftest.py is supposed to skip any RGW tests if the platform is AWS, but it seems to fail in some cases. For example: https://url.corp.redhat.com/e54fa9b.
Perhaps the config.ENV_DATA["platform"] is changed as a side effect due to the upgrade?

When this happens, the creation attempt via the bucket factory fails with the following error:

 bucketname = rgw_bucket_factory(1, "rgw-oc")[0].name
E       TypeError: 'NoneType' object is not callable

In such scenarios this error is expected, because that in the context of OCS-CI, RGW buckets can only be created on on-prem clusters such as vSphere.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

[tiffanyn108]

Seen the same issue in bearmetal cluster:
https://reportportal-ocs4.apps.ocp-c1.prod.psi.redhat.com/ui/#ocs/launches/678/22008/1046133/1046322/log
https://reportportal-ocs4.apps.ocp-c1.prod.psi.redhat.com/ui/#ocs/launches/678/22008/1046133/1046323/log

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.