Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript updates and fixes #648

Merged
merged 4 commits into from
Oct 7, 2020
Merged

TypeScript updates and fixes #648

merged 4 commits into from
Oct 7, 2020

Conversation

dbrudner
Copy link
Contributor

@dbrudner dbrudner commented Oct 5, 2020

  1. Adds types for configuring recurly.js with hosted fields (Incomplete typings #646)

  2. Updates types for PayPal events to includes cancel and ready (Incomplete typings #646)

  3. Fixes element.style.invalid type by making it optional instead of required

  4. Fixes scoped package naming

@dbrudner dbrudner changed the title Ts updates TypeScript updates and fixes Oct 5, 2020
@dbrudner dbrudner added the types label Oct 5, 2020
@dbrudner dbrudner force-pushed the ts-updates branch 2 times, most recently from 2a89708 to ba42c14 Compare October 5, 2020 14:18
@coveralls
Copy link

coveralls commented Oct 5, 2020

Coverage Status

Coverage remained the same at 93.253% when pulling 3a45e97 on ts-updates into d613c6e on master.

- Unmangles scoped package name where appropriate.
- The only references to the mangled package name (recurly__recurly-js)
should be when referencing DefinitelyTyped's file structure, e.g. the DT
GitHub action
- Reference PRs includes
    - DefinitelyTyped/DefinitelyTyped#47115
    - DefinitelyTyped/DefinitelyTyped#48237
    - DefinitelyTyped/DefinitelyTyped#47173
@@ -15,6 +17,18 @@ export type RecurlyOptions = {
sessionId?: string;
};
};

/**
* @deprecated Use {@link https://developers.recurly.com/reference/recurly-js/index.html#elements|Elements} instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@chrissrogers chrissrogers merged commit 226d5e8 into master Oct 7, 2020
@chrissrogers chrissrogers deleted the ts-updates branch October 7, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants