-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript updates and fixes #648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrudner
force-pushed
the
ts-updates
branch
2 times, most recently
from
October 5, 2020 14:18
2a89708
to
ba42c14
Compare
- Unmangles scoped package name where appropriate. - The only references to the mangled package name (recurly__recurly-js) should be when referencing DefinitelyTyped's file structure, e.g. the DT GitHub action - Reference PRs includes - DefinitelyTyped/DefinitelyTyped#47115 - DefinitelyTyped/DefinitelyTyped#48237 - DefinitelyTyped/DefinitelyTyped#47173
chrissrogers
reviewed
Oct 7, 2020
@@ -15,6 +17,18 @@ export type RecurlyOptions = { | |||
sessionId?: string; | |||
}; | |||
}; | |||
|
|||
/** | |||
* @deprecated Use {@link https://developers.recurly.com/reference/recurly-js/index.html#elements|Elements} instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
chrissrogers
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types for configuring recurly.js with hosted fields (Incomplete typings #646)
Updates types for PayPal events to includes
cancel
andready
(Incomplete typings #646)Fixes
element.style.invalid
type by making it optional instead of requiredFixes scoped package naming