Updated Rector to commit b6353b73d2497e03392587b40a497251aa662e6d

rectorphp/rector-src@b6353b7 [depre] Deprecate RenameFunctionLikeParamWithinCallLikeArgRector as never used, too narrow and better suits custom project (#7544)

Author: TomasVotruba

rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php

@@ -4,53 +4,21 @@
 namespace Rector\Renaming\Rector\FunctionLike;
 
 use PhpParser\Node;
-use PhpParser\Node\Arg;
-use PhpParser\Node\Expr\ArrowFunction;
 use PhpParser\Node\Expr\CallLike;
-use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
-use PhpParser\Node\Expr\Variable;
-use PhpParser\Node\FunctionLike;
-use PhpParser\Node\Identifier;
-use PhpParser\Node\Param;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
 use Rector\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Naming\Guard\BreakingVariableRenameGuard;
-use Rector\Naming\ParamRenamer\ParamRenamer;
-use Rector\Naming\ValueObject\ParamRename;
-use Rector\Naming\ValueObjectFactory\ParamRenameFactory;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
 use Rector\Renaming\ValueObject\RenameFunctionLikeParamWithinCallLikeArg;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
-use RectorPrefix202510\Webmozart\Assert\Assert;
 /**
- * @see \Rector\Tests\Renaming\Rector\FunctionLike\RenameFunctionLikeParamWithinCallLikeArgRector\RenameFunctionLikeParamWithinCallLikeArgRectorTest
+ * @deprecated as very narrow use case and suited better for custom rule.
  */
-final class RenameFunctionLikeParamWithinCallLikeArgRector extends AbstractRector implements ConfigurableRectorInterface
+final class RenameFunctionLikeParamWithinCallLikeArgRector extends AbstractRector implements ConfigurableRectorInterface, DeprecatedInterface
 {
-    /**
-     * @readonly
-     */
-    private BreakingVariableRenameGuard $breakingVariableRenameGuard;
-    /**
-     * @readonly
-     */
-    private ParamRenamer $paramRenamer;
-    /**
-     * @readonly
-     */
-    private ParamRenameFactory $paramRenameFactory;
-    /**
-     * @var RenameFunctionLikeParamWithinCallLikeArg[]
-     */
-    private array $renameFunctionLikeParamWithinCallLikeArgs = [];
-    public function __construct(BreakingVariableRenameGuard $breakingVariableRenameGuard, ParamRenamer $paramRenamer, ParamRenameFactory $paramRenameFactory)
-    {
-        $this->breakingVariableRenameGuard = $breakingVariableRenameGuard;
-        $this->paramRenamer = $paramRenamer;
-        $this->paramRenameFactory = $paramRenameFactory;
-    }
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Rename param within closures and arrow functions based on use with specified method calls', [new ConfiguredCodeSample(<<<'CODE_SAMPLE'
@@ -73,110 +41,12 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $hasChanged = \false;
-        foreach ($this->renameFunctionLikeParamWithinCallLikeArgs as $renameFunctionLikeParamWithinCallLikeArg) {
-            if (!$node instanceof MethodCall && !$node instanceof StaticCall) {
-                continue;
-            }
-            switch (\true) {
-                case $node instanceof MethodCall:
-                    $type = $node->var;
-                    break;
-                case $node instanceof StaticCall:
-                    $type = $node->class;
-                    break;
-            }
-            if (!$this->isObjectType($type, $renameFunctionLikeParamWithinCallLikeArg->getObjectType())) {
-                continue;
-            }
-            if (!$node->name instanceof Identifier) {
-                continue;
-            }
-            if (!$this->isName($node->name, $renameFunctionLikeParamWithinCallLikeArg->getMethodName())) {
-                continue;
-            }
-            $arg = $this->findArgFromMethodCall($renameFunctionLikeParamWithinCallLikeArg, $node);
-            $functionLike = ($nullsafeVariable1 = $arg) ? $nullsafeVariable1->value : null;
-            if (!$arg instanceof Arg) {
-                continue;
-            }
-            if (!$functionLike instanceof FunctionLike) {
-                continue;
-            }
-            $param = $this->findParameterFromArg($arg, $renameFunctionLikeParamWithinCallLikeArg);
-            if (!$param instanceof Param) {
-                continue;
-            }
-            if (!$param->var instanceof Variable) {
-                continue;
-            }
-            if (($functionLike instanceof Closure || $functionLike instanceof ArrowFunction) && $this->breakingVariableRenameGuard->shouldSkipVariable($this->getName($param), $renameFunctionLikeParamWithinCallLikeArg->getNewParamName(), $functionLike, $param->var)) {
-                continue;
-            }
-            $paramRename = $this->paramRenameFactory->createFromResolvedExpectedName($functionLike, $param, $renameFunctionLikeParamWithinCallLikeArg->getNewParamName());
-            if (!$paramRename instanceof ParamRename) {
-                continue;
-            }
-            $this->paramRenamer->rename($paramRename);
-            $hasChanged = \true;
-        }
-        if (!$hasChanged) {
-            return null;
-        }
-        return $node;
+        throw new ShouldNotHappenException(sprintf('"%s" rule is deprecated as too specific and not practical for general core rules', self::class));
     }
     /**
      * @param RenameFunctionLikeParamWithinCallLikeArg[] $configuration
      */
     public function configure(array $configuration): void
     {
-        Assert::allIsAOf($configuration, RenameFunctionLikeParamWithinCallLikeArg::class);
-        $this->renameFunctionLikeParamWithinCallLikeArgs = $configuration;
-    }
-    public function findParameterFromArg(Arg $arg, RenameFunctionLikeParamWithinCallLikeArg $renameFunctionLikeParamWithinCallLikeArg): ?Param
-    {
-        $functionLike = $arg->value;
-        if (!$functionLike instanceof FunctionLike) {
-            return null;
-        }
-        return $functionLike->params[$renameFunctionLikeParamWithinCallLikeArg->getFunctionLikePosition()] ?? null;
-    }
-    private function findArgFromMethodCall(RenameFunctionLikeParamWithinCallLikeArg $renameFunctionLikeParamWithinCallLikeArg, CallLike $callLike): ?Arg
-    {
-        if (is_int($renameFunctionLikeParamWithinCallLikeArg->getCallLikePosition())) {
-            return $this->processPositionalArg($callLike, $renameFunctionLikeParamWithinCallLikeArg);
-        }
-        return $this->processNamedArg($callLike, $renameFunctionLikeParamWithinCallLikeArg);
-    }
-    private function processPositionalArg(CallLike $callLike, RenameFunctionLikeParamWithinCallLikeArg $renameFunctionLikeParamWithinCallLikeArg): ?Arg
-    {
-        if ($callLike->isFirstClassCallable()) {
-            return null;
-        }
-        if ($callLike->getArgs() === []) {
-            return null;
-        }
-        $arg = $callLike->args[$renameFunctionLikeParamWithinCallLikeArg->getCallLikePosition()] ?? null;
-        if (!$arg instanceof Arg) {
-            return null;
-        }
-        // int positions shouldn't have names
-        if ($arg->name instanceof Identifier) {
-            return null;
-        }
-        return $arg;
-    }
-    private function processNamedArg(CallLike $callLike, RenameFunctionLikeParamWithinCallLikeArg $renameFunctionLikeParamWithinCallLikeArg): ?Arg
-    {
-        $args = array_filter($callLike->getArgs(), static function (Arg $arg) use ($renameFunctionLikeParamWithinCallLikeArg): bool {
-            if (!$arg->name instanceof Identifier) {
-                return \false;
-            }
-            return $arg->name->name === $renameFunctionLikeParamWithinCallLikeArg->getCallLikePosition();
-        });
-        if ($args === []) {
-            return null;
-        }
-        return array_values($args)[0];
     }
 }

rules/Renaming/ValueObject/RenameFunctionLikeParamWithinCallLikeArg.php

@@ -5,6 +5,9 @@
 
 use PHPStan\Type\ObjectType;
 use Rector\Validation\RectorAssert;
+/**
+ * @deprecated as related rule is deprecated
+ */
 final class RenameFunctionLikeParamWithinCallLikeArg
 {
     /**

src/Application/VersionResolver.php

@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = '38ecb98e65a29d6a774f93013a32cf8d8d4e482e';
+    public const PACKAGE_VERSION = 'b6353b73d2497e03392587b40a497251aa662e6d';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2025-10-23 00:09:12';
+    public const RELEASE_DATE = '2025-10-23 00:28:12';
     /**
      * @var int
      */

src/Config/Level/TypeDeclarationDocblocksLevel.php

@@ -12,6 +12,7 @@
 use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarArrayFromPropertyDefaultsRector;
 use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarFromParamDocblockInConstructorRector;
 use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockBasedOnArrayMapRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromAssignsParamToParamReferenceRector;
 use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDataProviderRector;
 use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector;
 use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForArrayDimAssignedObjectRector;
@@ -35,6 +36,7 @@ final class TypeDeclarationDocblocksLevel
         AddParamArrayDocblockFromDimFetchAccessRector::class,
         ClassMethodArrayDocblockParamFromLocalCallsRector::class,
         AddParamArrayDocblockBasedOnArrayMapRector::class,
+        AddParamArrayDocblockFromAssignsParamToParamReferenceRector::class,
         // return
         AddReturnDocblockForCommonObjectDenominatorRector::class,
         AddReturnArrayDocblockBasedOnArrayMapRector::class,