[CodeQuality] Do not replace variable assign on ControllerMethodInjectionToConstructorRector (#883)

* [CodeQuality] Do not replace variable assign on ControllerMethodInjectionToConstructorRector

* fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/do_not_replace_variable_assign.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+
+final class DoNotReplaceVariableAssign extends AbstractController
+{
+    public function someAction(\Psr\Log\LoggerInterface $logger)
+    {
+        $logger = $this->modify($logger);
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+
+final class DoNotReplaceVariableAssign extends AbstractController
+{
+    public function __construct(private readonly \Psr\Log\LoggerInterface $logger)
+    {
+    }
+    public function someAction()
+    {
+        $logger = $this->modify($this->logger);
+    }
+}
+
+?>

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -14,6 +14,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
 use Rector\NodeManipulator\ClassDependencyManipulator;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\PostRector\ValueObject\PropertyMetadata;
 use Rector\Rector\AbstractRector;
@@ -190,7 +191,10 @@ public function refactor(Node $node): ?Node
 
                 if (! $this->isNames($node, $paramNamesToReplace)) {
                     return null;
+                }
 
+                if ($node->getAttribute(AttributeKey::IS_BEING_ASSIGNED) === true) {
+                    return null;
                 }
 
                 $propertyName = $this->getName($node);