[CodeQuality] Skip used in next stmt on UnusedForeachValueToArrayKeysRector

[samsonasik]

Fixes rectorphp/rector#8753

[samsonasik]

Fixed 🎉 /cc @sreichel

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[sreichel]

WOW! Thanks. 💯

I'll test it later.

[sreichel]

@samsonasik just a question ... is it possible to check HOW a value is used after foreach?

Eg ...

foreach ($array as $key => $unUsedValue) {
    ....
}

unset($key, $unUsedValue);

Could turn into

foreach (array_keys($array) as $key) {
    ....
}

unset($key);

In this case the rule could be applied when $unUsedValue also gots removed from unset().

Is it too complex to cover all possiblities?

[samsonasik]

this should already covered by this patch, but feel free to provide a failing test case if the issue persist.

[sreichel]

Time for me to learn "rectorphp" :)

Thanks for you work!

[TomasVotruba]

👍

[sreichel]

this should already covered by this patch, but feel free to provide a failing test case if the issue persist.

https://getrector.com/demo/e2d93df1-5c99-4ed6-912d-4ccebb276d8c

FYI. Its not an issue. Your change works as aspected.