[perf] optimize ParamTypeByMethodCallTypeRector for speed with early checks

Author: TomasVotruba

rules-tests/CodingStyle/ClassNameImport/ShortNameResolver/ShortNameResolverTest.php

@@ -18,7 +18,6 @@ final class ShortNameResolverTest extends AbstractLazyTestCase
 
     protected function setUp(): void
     {
-        // @todo let dynamic source locator know about parsed files
         parent::setUp();
 
         $this->shortNameResolver = $this->make(ShortNameResolver::class);

rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php

@@ -106,6 +106,15 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        if ($node->params === []) {
+            return null;
+        }
+
+        // has params with at least one missing type
+        if (! $this->hasAtLeastOneParamWithoutType($node)) {
+            return null;
+        }
+
         if ($node instanceof ClassMethod && $this->shouldSkipClassMethod($node)) {
             return null;
         }
@@ -116,7 +125,16 @@ public function refactor(Node $node): ?Node
             [StaticCall::class, MethodCall::class, FuncCall::class]
         );
 
-        $hasChanged = $this->refactorFunctionLike($node, $callers);
+        // keep only callers with args
+        $callersWithArgs = array_filter($callers, function (StaticCall|MethodCall|FuncCall $caller): bool {
+            return $caller->args !== [];
+        });
+
+        if ($callersWithArgs === []) {
+            return null;
+        }
+
+        $hasChanged = $this->refactorFunctionLike($node, $callersWithArgs);
         if ($hasChanged) {
             return $node;
         }
@@ -126,10 +144,6 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkipClassMethod(ClassMethod $classMethod): bool
     {
-        if ($classMethod->params === []) {
-            return true;
-        }
-
         $isMissingParameterTypes = false;
         foreach ($classMethod->params as $param) {
             if ($param->type instanceof Node) {
@@ -218,4 +232,15 @@ private function refactorFunctionLike(
 
         return $hasChanged;
     }
+
+    private function hasAtLeastOneParamWithoutType(ClassMethod|Function_|Closure|ArrowFunction $functionLike): bool
+    {
+        foreach ($functionLike->params as $param) {
+            if (! $param->type instanceof Node) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }