cs

Author: TomasVotruba

rules/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector.php

@@ -85,10 +85,12 @@ public function refactor(Node $node): ?Node
 
         foreach ($node->params as $param) {
             // skip as array-like
-            if ($param->variadic || $param->type === null) {
+            if ($param->variadic) {
+                continue;
+            }
+            if ($param->type === null) {
                 continue;
             }
-
             if ($node instanceof ClassMethod && $this->shouldSkipClassMethodFromVendor($node)) {
                 return null;
             }

rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector.php

@@ -135,8 +135,8 @@ public function refactor(Node $node): ?Node
                 $paramType = $parentParam->type;
 
                 // original attributes have to removed to avoid tokens crashing from origin positions
-                $this->traverseNodesWithCallable($paramType, static function (Node $classMethod): null {
-                    $classMethod->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+                $this->traverseNodesWithCallable($paramType, static function (Node $node): null {
+                    $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
                     return null;
                 });
 

rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php

@@ -185,10 +185,14 @@ private function shouldSkipPropertyType(Type $propertyType): bool
         return $this->doctrineTypeAnalyzer->isInstanceOfCollectionType($propertyType);
     }
 
-    private function hasSomeUntypedProperties(Node|Class_ $node): bool
+    private function hasSomeUntypedProperties(Class_ $class): bool
     {
-        foreach ($node->getProperties() as $property) {
-            if ($property->type instanceof \PhpParser\Node) {
+        if ($class->getProperties() === []) {
+            return false;
+        }
+
+        foreach ($class->getProperties() as $property) {
+            if ($property->type instanceof Node) {
                 continue;
             }