New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`algorithms/div/small`: This implementation is off by one. #180

Open

github-actions bot opened this issue Oct 24, 2022 · 0 comments

Assignees

Labels

github-actions bot commented Oct 24, 2022

On 2022-10-24 @recmo wrote in fb3aa20 “Merge pull request #172 from recmo/div2”:

This implementation is off by one.

        (q1, r)
    };
    (q1, r)
}

/// TODO: This implementation is off by one.
#[inline(always)]
#[must_use]
pub fn div_3x2_ref(n21: u128, n0: u64, d: u128) -> u64 {
    debug_assert!(d >= (1 << 127));
    debug_assert!(n21 < d);

From src/algorithms/div/small.rs:202

The text was updated successfully, but these errors were encountered:

github-actions bot added to do tracker labels

github-actions bot assigned recmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment