-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 10 support #983
Merged
Merged
Laravel 10 support #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Nice, thanks! Will try to get to it ASAP, but a bit busy this week |
No worries. Thanks! |
mfn
reviewed
Feb 18, 2023
Merged
mfn
approved these changes
Feb 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my suggested fix will be merged via #984
Release tagged! https://github.com/rebing/graphql-laravel/releases/tag/8.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Laravel 10 support.
lang()
helper instead of the stringsOnly issue is code analysis:
PHPStan is now failing. This is a little over my head. I had to require v2 of larastan in order for Laravel 10 to be installable. I removed the phpstan explicit requirement so larastan can deal with that. Maybe that's why it's failing. Or maybe it has to do with all the typehints added to Laravel 10.
I noticed in this commit that you required explicit versions. Not sure of the story behind that.
From my end, this PR is done / ready for review. Let me know what you want done regarding Larastan/PHPStan.
Type of change:
Checklist:
composer fix-style