Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix security alerts (who cares?) #132

Closed
andywhite37 opened this issue Jun 12, 2019 · 1 comment
Closed

Fix security alerts (who cares?) #132

andywhite37 opened this issue Jun 12, 2019 · 1 comment
Labels
type:enhancement New feature or request

Comments

@andywhite37
Copy link
Member

andywhite37 commented Jun 12, 2019 •
edited
Loading

We're getting a security alert in github for a vulnerability in marked, which is a dependency of docsify, which powers the doc site.

There is a PR in docsify to bump marked to a safe version:

docsifyjs/docsify#862

This PR is for a different issue, but upgrading marked will fix our security alert.
@andywhite37 andywhite37 added the type:enhancement New feature or request label Jun 14, 2019
@andywhite37 andywhite37 changed the title Fix marked security alert Fix security alerts (who cares?) Oct 21, 2019
@mlms13
Copy link
Member

mlms13 commented Dec 12, 2019

The relevant PR has been closed, but there doesn't appear to be an end in sight to security alerts out of docsify... Maybe this is just the state of affairs in the JS world? Luckily "security alerts" for our docs website are not super important, so I vote we just ignore it.

@mlms13 mlms13 closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andywhite37 @mlms13