fix: quoted extensions regression -- preserve extension printing for non-quoted ext #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Nov 29, 2024
CHANGES: - Support OCaml 5.3 (@anmonteiro, [reasonml/reason#2800](reasonml/reason#2800)) - Fix: don't print all extension strings as quoted extensions (@anmonteiro, [reasonml/reason#2809](reasonml/reason#2809)) - Fix: unify printing of extensions across structure items / expressions (@anmonteiro, [reasonml/reason#2814](reasonml/reason#2814))
davesnx
added a commit
that referenced
this pull request
Dec 15, 2025
* 'master' of github.com:/reasonml/reason: (94 commits) feat: add raw identifier syntax (#2796) fix(rtop): try load `~/.config/rtop/init.re`, don't load utop config files (#2813) prep 3.14 refactor(build): use inferred form of `with-stdout-to` (#2819) build: fix warning 9 across the codebase (#2818) bump dune version to 3, remove unused settings (#2817) use ocaml 5.3 beta 2 (#2816) fix: better printing of `Pexp_extension` (#2814) OCaml 5.3 updates, fmt (#2812) chore: fix some comments (#2782) chore: add changelog entry for #2800 ci: run fewer macOS runs (#2810) fix: quoted extensions regression -- preserve extension printing for non-quoted ext (#2809) chore: remove trailing whitespace from version test chore: make version test more flexible in parsing (#2808) OCaml 5.3 support (#2800) nix workflow: trim macOS runs (#2807) chore: prep 3.13 fix: print module expr attributes (#2803) chore: bump CI actions versions (#2806) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.