Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): correctly display duration of stopped workflows (#701) #701

Merged

Conversation

giuseppe-steduto
Copy link
Member

Closes #699

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02dc830) 58.57% compared to head (b53def8) 58.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   58.57%   58.62%   +0.05%     
==========================================
  Files          24       24              
  Lines        2390     2393       +3     
==========================================
+ Hits         1400     1403       +3     
  Misses        990      990              
Files Coverage Δ
reana_client/utils.py 76.47% <100.00%> (+0.60%) ⬆️

@giuseppe-steduto
Copy link
Member Author

Note for the reviewer: I chose status as the scope of the commit because I think that the commands affected by the PR are a nice user-facing scope for changes to the client. For example, this PR fixes status, list, and in general the commands that use the --include-duration flag, I chose status as it is the one most evidently impacted. WDYT?

Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Needs a rebase 😉

@mdonadoni
Copy link
Member

mdonadoni commented Jan 31, 2024

Regarding the scope, I think fix(status) can be a good choice. WDYT @tiborsimko ?
To be pedantic, I would change the commit message to display correct duration ..., just to keep the verb as the first word of the message.

@giuseppe-steduto giuseppe-steduto force-pushed the fix-duration-stopped-workflows branch from d3925f2 to b53def8 Compare February 1, 2024 09:06
@mdonadoni mdonadoni merged commit b53def8 into reanahub:master Feb 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: duration of stopped workflows is not displayed correctly
2 participants