Allow private(set) on IBOutlets #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fantastic! Stellar work @HaloZero 👏 . Tests pass locally for me, so I'm happy to get this in. |
| @@ -47,8 +47,13 @@ public struct PrivateOutletRule: ASTRule, OptInRule, ConfigurationProviderRule { | |||
|
|
|||
| // Check if private | |||
| let accessibility = (dictionary["key.accessibility"] as? String) ?? "" | |||
| let setterAccesiblity = (dictionary["key.setter_accessibility"] as? String) ?? "" | |||
|
Should this be configurable at all? It seems like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a configuration to the
private_outletrule to allow forprivate(set).private(set)can be useful. Sometimes you can have components that can expose their views for information retrieval, modification of components (say alpha transparency), or maybe setting callbacks on view components for later reuse but shouldn't allow their full write modification.I made it a configuration to allow people to control it or not, by default false as the rule is more specifically geared toward private outlets.