Add excluded_match_kinds custom rule config parameter
#3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #3336 +/- ##
==========================================
+ Coverage 90.56% 90.58% +0.01%
==========================================
Files 416 416
Lines 20357 20406 +49
==========================================
+ Hits 18437 18485 +48
- Misses 1920 1921 +1
Continue to review full report at Codecov.
|
jpsim
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows custom rules to define an
excluded_match_kindsarray instead of listing out all but one or a few of theSyntaxKinds inmatch_kinds. Rules that include bothmatch_kindsandexcluded_match_kindswill be invalid, since there's not an obvious way to resolve the two without an arbitrary priority between them.