Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prohibited_nan_comparison opt-in rule #3089

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Conversation

marcelofabri
Copy link
Collaborator

@marcelofabri marcelofabri commented Feb 8, 2020

Fixes #2086

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 1.3s vs 1.25s on master (4% slower)
📖 Linting Alamofire with this PR took 2.33s vs 2.27s on master (2% slower)
📖 Linting Firefox with this PR took 9.77s vs 9.43s on master (3% slower)
📖 Linting Kickstarter with this PR took 16.1s vs 15.66s on master (2% slower)
📖 Linting Moya with this PR took 1.22s vs 1.22s on master (0% slower)
📖 Linting Nimble with this PR took 1.44s vs 1.4s on master (2% slower)
📖 Linting Quick with this PR took 0.56s vs 0.55s on master (1% slower)
📖 Linting Realm with this PR took 2.52s vs 2.47s on master (2% slower)
📖 Linting SourceKitten with this PR took 1.09s vs 1.07s on master (1% slower)
📖 Linting Sourcery with this PR took 7.2s vs 6.99s on master (3% slower)
📖 Linting Swift with this PR took 13.2s vs 12.98s on master (1% slower)
📖 Linting WordPress with this PR took 16.02s vs 15.81s on master (1% slower)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit fdd16a6 into master Feb 9, 2020
jpsim added a commit that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Request: Forbid NaN comparison
2 participants