Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Swift 5.0 to build #2857

Merged
merged 6 commits into from
Sep 3, 2019
Merged

Require Swift 5.0 to build #2857

merged 6 commits into from
Sep 3, 2019

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Sep 3, 2019

  • Update READMEs
  • Remove Swift 4.x compatibility shims
  • Update CI
    • Stop testing with Swift 4.x & Xcode 10.0/10.1
    • Use official Swift docker image instead of norionomura's
    • Use Xcode 10.3 as latest stable version

* Stop testing with Swift 4.x & Xcode 10.0/10.1
* Use official Swift docker image instead of norionomura's
* Use Xcode 10.3 as latest stable version
@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 3.11s vs 3.42s on master (9% faster)
📖 Linting Alamofire with this PR took 6.88s vs 7.06s on master (2% faster)
📖 Linting Firefox with this PR took 18.2s vs 19.34s on master (5% faster)
📖 Linting Kickstarter with this PR took 33.29s vs 29.5s on master (12% slower)
📖 Linting Moya with this PR took 3.0s vs 2.93s on master (2% slower)
📖 Linting Nimble with this PR took 2.57s vs 2.42s on master (6% slower)
📖 Linting Quick with this PR took 0.91s vs 0.91s on master (0% slower)
📖 Linting Realm with this PR took 4.61s vs 4.2s on master (9% slower)
📖 Linting SourceKitten with this PR took 1.81s vs 1.72s on master (5% slower)
📖 Linting Sourcery with this PR took 5.34s vs 5.15s on master (3% slower)
📖 Linting Swift with this PR took 46.81s vs 39.92s on master (17% slower)
📖 Linting WordPress with this PR took 44.54s vs 40.45s on master (10% slower)

Generated by 🚫 Danger

@jpsim jpsim merged commit ffb2f4f into master Sep 3, 2019
@jpsim jpsim deleted the require-swift-5.0 branch September 3, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants