Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WeakComputedProperyRule #2761

Merged
merged 2 commits into from
May 16, 2019
Merged

Remove WeakComputedProperyRule #2761

merged 2 commits into from
May 16, 2019

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented May 16, 2019

Addresses #2712

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 3.19s vs 3.15s on master (1% slower)
📖 Linting Alamofire with this PR took 5.23s vs 5.29s on master (1% faster)
📖 Linting Firefox with this PR took 13.86s vs 13.88s on master (0% faster)
📖 Linting Kickstarter with this PR took 27.06s vs 27.4s on master (1% faster)
📖 Linting Moya with this PR took 2.87s vs 2.64s on master (8% slower)
📖 Linting Nimble with this PR took 2.25s vs 2.3s on master (2% faster)
📖 Linting Quick with this PR took 0.83s vs 0.81s on master (2% slower)
📖 Linting Realm with this PR took 3.92s vs 3.92s on master (0% slower)
📖 Linting SourceKitten with this PR took 1.53s vs 1.54s on master (0% faster)
📖 Linting Sourcery with this PR took 4.98s vs 5.04s on master (1% faster)
📖 Linting Swift with this PR took 38.52s vs 39.19s on master (1% faster)
📖 Linting WordPress with this PR took 30.6s vs 30.54s on master (0% slower)

Generated by 🚫 Danger

@jpsim jpsim merged commit c216ccc into master May 16, 2019
@jpsim jpsim deleted the remove-weak-computed-property branch May 16, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants