Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in identical_operands #2565

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jan 17, 2019

Fix false positives on identical_operands rule when the right side of the operand has a chained optional. Fixes #2564.

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 1.9s vs 1.75s on master (8% slower)
📖 Linting Alamofire with this PR took 3.9s vs 3.71s on master (5% slower)
📖 Linting Firefox with this PR took 13.18s vs 12.33s on master (6% slower)
📖 Linting Kickstarter with this PR took 19.99s vs 19.74s on master (1% slower)
📖 Linting Moya with this PR took 1.95s vs 2.46s on master (20% faster)
📖 Linting Nimble with this PR took 1.95s vs 2.47s on master (21% faster)
📖 Linting Quick with this PR took 0.58s vs 0.76s on master (23% faster)
📖 Linting Realm with this PR took 3.87s vs 3.95s on master (2% faster)
📖 Linting SourceKitten with this PR took 1.3s vs 1.37s on master (5% faster)
📖 Linting Sourcery with this PR took 4.68s vs 5.49s on master (14% faster)
📖 Linting Swift with this PR took 27.67s vs 28.23s on master (1% faster)
📖 Linting WordPress with this PR took 20.36s vs 20.47s on master (0% faster)

Generated by 🚫 Danger

@jpsim jpsim merged commit a92c687 into master Jan 17, 2019
@jpsim jpsim deleted the fix-identical-operands-optional branch January 17, 2019 21:57
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants