Stringify swiftlint_version #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to treat any specified value that doesn't match the version string to fail the lint.
This was referenced Dec 23, 2018
Generated by 🚫 Danger |
sjavora
pushed a commit
to sjavora/SwiftLint
that referenced
this pull request
Mar 9, 2019
to treat any specified value that doesn't match the version string to fail the lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to treat any specified value that doesn't match the version string to fail the lint.
Previously if
swiftlint_version: 0.29was specified in the configuration file, any SwiftLint version successfully ran because technically no string was specified as a yaml value.Now SwiftLint will log the following and exit:
Fixes #2518.