Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cp -Rf instead of cp -rf in Makefile #223

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

norio-nomura
Copy link
Collaborator

-r option of cp copies symbolic links as normal files.
As the result of that, SwiftLintFramework.framework that distributed by Homebrew contains a lot of duplicated files inside that.
-R option copies symbolic links as symbolic links.

On my testing, this fix reduces the size of swiftlint-0.4.0.el_capitan.bottle.tar.gz from 17.2MB to 4.3MB.

`-r` option of `cp` copies symbolic links as normal files.
As the result of that, SwiftLintFramework.framework that distributed by Homebrew contains a lot of duplicated files inside that.
`-R` option copies symbolic links as symbolic links.

On my testing, this fix reduces the size of swiftlint-0.4.0.el_capitan.bottle.tar.gz from 17.2MB to 4.3MB.
@norio-nomura
Copy link
Collaborator Author

Carthage/Carthage#932

@jpsim
Copy link
Collaborator

jpsim commented Nov 20, 2015

Sweet, thanks!

jpsim added a commit that referenced this pull request Nov 20, 2015
Use `cp -Rf` instead of `cp -rf` in Makefile
@jpsim jpsim merged commit d881402 into realm:master Nov 20, 2015
@norio-nomura norio-nomura deleted the fix-make-prefix_install branch November 20, 2015 23:38
@norio-nomura
Copy link
Collaborator Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants