Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set a threshold of warnings to throw an error #696

Closed
corentinfoure opened this issue Jun 15, 2016 · 5 comments
Closed

Ability to set a threshold of warnings to throw an error #696

corentinfoure opened this issue Jun 15, 2016 · 5 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@corentinfoure
Copy link

I've looked for this in the issues, but haven't found it...

It would be cool to set a warning threshold to raise an error

warning_threshold: 20
@jpsim jpsim added the enhancement Ideas for improvements of existing features and rules. label Jun 15, 2016
@jpsim
Copy link
Collaborator

jpsim commented Jun 15, 2016

This is fairly easy to build, so @Nitner0C I'd encourage you to try implementing this yourself if you're looking for ways to contribute 😄

@ghost
Copy link

ghost commented Jul 5, 2016

I would love this too!

@jpsim Could you point me in the right direction? Id love to look into contributing :)

@ghost
Copy link

ghost commented Jul 6, 2016

Ive prototyped something up, but it just counts the warnings thrown by swiftlint.

Would you know if there is anyway we could pass the number of warnings currently in the project from xcode to swiftlint when we start linting. The reason is

Say we have 5 warnings in the project and then when we lint we get another 15 warnings I would like to throw an error as the total is 20 or above

@jpsim

@ghost ghost mentioned this issue Jul 7, 2016
@ghost ghost mentioned this issue Aug 14, 2016
@marcelofabri
Copy link
Collaborator

I think this can be closed as #757 was merged

@norio-nomura
Copy link
Collaborator

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

4 participants