Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swiftlint set trailing_whitespace warning for comments #576

Closed
Sega-Zero opened this issue Mar 3, 2016 · 3 comments
Closed

swiftlint set trailing_whitespace warning for comments #576

Sega-Zero opened this issue Mar 3, 2016 · 3 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@Sega-Zero
Copy link
Contributor

This rule is fine for a code, but why does it lint a comments too?
screenshot
@jpsim jpsim added question Question or doubts that needs discussion and clarification. Can become a bug or proposal. enhancement Ideas for improvements of existing features and rules. and removed question Question or doubts that needs discussion and clarification. Can become a bug or proposal. labels Mar 4, 2016
@jpsim
Copy link
Collaborator

jpsim commented Mar 4, 2016

Given that documentation comments should use markdown, and that trailing whitespace has meaning, I'm inclined to agree with you that this rule should be disabled for comments.

@masters3d
Copy link
Contributor

Should this be configurable? Or just make it the default to ignore comments?

@jpsim
Copy link
Collaborator

jpsim commented Aug 21, 2016

IMHO this should be both configurable, AND default to ignore comments.

@jaherhi jaherhi mentioned this issue Oct 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpsim @Sega-Zero @masters3d