Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces in function arguments #5224

Open
sedenkovvlad opened this issue Sep 15, 2023 · 1 comment · May be fixed by #5337
Open

Spaces in function arguments #5224

sedenkovvlad opened this issue Sep 15, 2023 · 1 comment · May be fixed by #5337
Assignees
@u-abyss
Labels
good first issue Issue to be taken up by new contributors yet unfamiliar with the project. rule-request Requests for a new rules.

Comments

@sedenkovvlad
Copy link

sedenkovvlad commented Sep 15, 2023 •
edited
Loading

I would like to remove spaces before the first function argument and after the last function argument. The rule must be opt-in. Need good style code

Bad

makeGenerator(❗️ style ❗️)
makeGenerator(❗️ style)
makeGenerator(style ❗️)
makeGenerator(❗️ offset: 0, limit: 0)
makeGenerator(offset: 0, limit: 0 ❗️)

Good

makeGenerator(style)
makeGenerator(style)
makeGenerator(style)
makeGenerator(offset: 0, limit: 0)
makeGenerator(offset: 0, limit: 0)
@SimplyDanny SimplyDanny added the rule-request Requests for a new rules. label Sep 24, 2023
@u-abyss
Copy link
Contributor

u-abyss commented Nov 4, 2023

I'll work on it

@u-abyss u-abyss linked a pull request Nov 8, 2023 that will close this issue
Open
@SimplyDanny SimplyDanny added the good first issue Issue to be taken up by new contributors yet unfamiliar with the project. label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@u-abyss u-abyss

Labels
good first issue Issue to be taken up by new contributors yet unfamiliar with the project. rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implements FunctionArgumentsSpacingRule u-abyss/SwiftLint
3 participants
@SimplyDanny @u-abyss @sedenkovvlad