Segmentation fault with nested configs and autocorrect.

[scottrhoyt]

Not 100% sure on this one. Was getting a segmentation fault using autocorrect, and I removed enable_nesting_configs: true and it went away. There might be something to investigate here.

[nicolai86]

@scottrhoyt can you enable the option use_nested_configs again and post the stacktrace?

[mlennon3]

I'm getting the same behavior..

$# swiftlint.yml has use_nested_configs: true
$ swiftlint version
0.6.0
$ swiftlint autocorrect
Loading configuration from '.swiftlint.yml'
Correcting Swift files in current working directory
Correcting 'myfile.swift' (1/68)
Segmentation fault: 11

when remove use_nested_configs: true, autocorrect works correctly. I'm on OSX 10.10.5.

[jpsim]

@mlennon3 how can we reproduce that? What about your configuration makes this crash? Can you build & run SwiftLint from Xcode so that LLDB shows where this is crashing?

Maybe if you shared the contents of your config files and their layout in the file system, we'd have more information to go on?

[mlennon3]

I created a shell project called nestedLint, which is an xcodeproj, and has no swift files besides the ones provided by xcode (AppDelegate, etc). I have:

$ pwd
~/tmp/nestedLint
$ ls -a
.                    ..                   .swiftlint.yml       myDir                nestedLint           nestedLint.xcodeproj
$ ls -a myDir/
.              ..             .swiftlint.yml
$ cat .swiftlint.yml
use_nested_configs: true
$ cat myDir/.swiftlint.yml
$
$ swiftlint autocorrect
Loading configuration from '.swiftlint.yml'
Correcting Swift files in current working directory
Correcting 'AppDelegate.swift' (1/2)
Segmentation fault: 11

[jpsim]

Hmm, I can't reproduce it like that:

$ cd /tmp
$ mkdir topdir
$ cd topdir
$ echo "use_nested_configs: true" > .swiftlint.yml
$ mkdir nested
$ touch nested/.swiftlint.yml nested/file.swift
$ swiftlint
Loading configuration from '.swiftlint.yml'
Linting Swift files in current working directory
Linting 'file.swift' (1/1)
/tmp/topdir/nested/file.swift:1: warning: Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
Done linting! Found 1 violation, 0 serious in 1 file.
$ swiftlint version
0.6.0

[mlennon3]

Did you try $swiftlint autocorrect ?

[jpsim]

Yes

[mlennon3]

OK so if I do the steps you have done there, i get no segfault.

If however, I don't mkdir topdir but instead create a project in Xcode called topdir, and do the rest as you have it written, I get segfault 11

[jpsim]

Still no luck:

$ cat .swiftlint.yml
use_nested_configs: true
$ cat LintSegFault/.swiftlint.yml
$ tree -a
.
├── .swiftlint.yml
├── LintSegFault
│   ├── .swiftlint.yml
│   ├── AppDelegate.swift
│   ├── Assets.xcassets
│   │   └── AppIcon.appiconset
│   │       └── Contents.json
│   ├── Base.lproj
│   │   ├── LaunchScreen.storyboard
│   │   └── Main.storyboard
│   ├── Info.plist
│   └── ViewController.swift
└── LintSegFault.xcodeproj
    ├── project.pbxproj
    └── project.xcworkspace
        └── contents.xcworkspacedata

6 directories, 10 files
$ swiftlint autocorrect
swiftlint autocorrect
Loading configuration from '.swiftlint.yml'
Correcting Swift files in current working directory
Correcting 'AppDelegate.swift' (1/2)
/tmp/LintSegFault/LintSegFault/AppDelegate.swift:45 Corrected Trailing Newline
Correcting 'ViewController.swift' (2/2)
/tmp/LintSegFault/LintSegFault/ViewController.swift:24 Corrected Trailing Newline
Done correcting 2 files!

[mlennon3]

Hm. Well I'm on XCode Version 7.2 (7C68)...

[jpsim]

$ xcodebuild -version
Xcode 7.2
Build version 7C68

[mlennon3]

OK here's a difference:

~/tmp/topdir
$ tree -a
.
├── .swiftlint.yml
├── nested
│   ├── .swiftlint.yml
│   └── file.swift
├── topdir
│   ├── AppDelegate.swift
│   ├── Assets.xcassets
│   │   └── AppIcon.appiconset
│   │       └── Contents.json
│   ├── Base.lproj
│   │   ├── LaunchScreen.storyboard
│   │   └── Main.storyboard
│   ├── Info.plist
│   └── ViewController.swift
└── topdir.xcodeproj
    ├── project.pbxproj
    ├── project.xcworkspace
    │   ├── contents.xcworkspacedata
    │   └── xcuserdata
    │       └── mslennon.xcuserdatad
    │           └── UserInterfaceState.xcuserstate
    └── xcuserdata
        └── mslennon.xcuserdatad
            └── xcschemes
                ├── topdir.xcscheme
                └── xcschememanagement.plist

This is like more how we have our directories structured in our real app than the example you gave..

[jpsim]

Aha! That last directory structure you shared was key in reproducing this:

$ mkdir topdir
$ cd topdir
$ mkdir one two
$ touch one/.swiftlint.yml two/two.swift
$ echo "use_nested_configs: true" > .swiftlint.yml
$ swiftlint autocorrect
Loading configuration from '.swiftlint.yml'
Correcting Swift files in current working directory
Correcting 'two.swift' (1/1)
[1]    51441 segmentation fault  swiftlint autocorrect

Thanks for your help, I think we can take it from here.

[mlennon3]

Great, thanks