Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates markdown documentation only for enabled rules. #2961

Closed
417-72KI opened this issue Nov 14, 2019 · 5 comments
Closed

Generates markdown documentation only for enabled rules. #2961

417-72KI opened this issue Nov 14, 2019 · 5 comments

Comments

@417-72KI
Copy link
Contributor

417-72KI commented Nov 14, 2019

Current generate-docs command makes Rules.md for all rules, but the generated file is too large and bothersome to find specific rule.

There are -e or -d options in rules command, which makes enabled to display only enabled / disabled rules on terminal.

I want similar options for generate-docs command.

Best regards.

@marcelofabri
Copy link
Collaborator

Can you elaborate why you're running this command?

The generate-docs command was added mainly for contributors to run - and it's now pretty much redundant as we have a unit test that generates the file instead. I was actually thinking about removing the command completely.

@417-72KI
Copy link
Contributor Author

417-72KI commented Jan 6, 2020

@marcelofabri
I often want to see an overview or an example of a particular SwiftLint rule (especially when setting up a rule), and ideally a Markdown-preview.
When there were few rules, Rules.md was useful because it was previewed.
However, it is no longer previewed on GitHub because the file is too heavy now.
Therefore, I thought that if only valid rules could be output to Rules.md, it would be possible to preview them again on GitHub.

Also, since rules settings are different for each OSS, Rules.md is managed for each repository, and if it is visualized, I think that development efficiency will increase.

@marcelofabri
Copy link
Collaborator

However, it is no longer previewed on GitHub because the file is too heavy now.
Therefore, I thought that if only valid rules could be output to Rules.md, it would be possible to preview them again on GitHub.

We're fixing this separately, see #3016

@417-72KI
Copy link
Contributor Author

417-72KI commented Jan 7, 2020

That's what I wanted and should be able to solve this problem.

I close this when it will be merged, thank you!

@jpsim
Copy link
Collaborator

jpsim commented Jan 8, 2020

Addressed in #3016.

@jpsim jpsim closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants