Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rule Request Modification] - PrivateUnitTestRule.swift Unit tests marked 'private' warning incorrect #2282

Closed
thefredelement opened this issue Jul 5, 2018 · 2 comments
Closed

[Rule Request Modification] - PrivateUnitTestRule.swift Unit tests marked 'private' warning incorrect #2282

thefredelement opened this issue Jul 5, 2018 · 2 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@thefredelement
Copy link

thefredelement commented Jul 5, 2018 •
edited
Loading

New Issue Checklist

Rule Request Modification

On an XCTestCase if a method is marked private the following warning triggers:
Private Unit Test Violation: Unit test marked "private" will not be run by XCTest. (private_unit_test)

However, if the @objc keyword is used it will run.
@realm-probot realm-probot bot added the O:User label Jul 5, 2018
@marcelofabri marcelofabri added the enhancement Ideas for improvements of existing features and rules. label Jul 5, 2018
@marcelofabri
Copy link
Collaborator

This seems reasonable and a great starter task! @thefredelement would you like to take a shot at it?

@thefredelement
Copy link
Author

@marcelofabri sure :).

@kimdv kimdv mentioned this issue Dec 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelofabri @thefredelement