Emitted warnings/errors should include a column number

[lilyball]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Bug Report

The output of SwiftLint is of the form

/path/to/file:15: warning: message goes here

Unfortunately, this doesn't play well with xcpretty, as xcpretty appears to require a column number for warnings (filed as xcpretty/xcpretty#321). It would be great if SwiftLint could start including column numbers so the output would be

/path/to/file:15:23: warning: message goes here

Environment

• SwiftLint version 0.25.1

[marcelofabri]

The Xcode formatter prints the column if it's available: https://github.com/realm/SwiftLint/blob/master/Source/SwiftLintFramework/Reporters/XcodeReporter.swift#L14

Maybe some rules are not setting it (only line). Is this happening to a particular rule?

[lilyball]

Right now I'm reproducing it with the vertical_whitespace rule.

[lilyball]

Looks like the xcpretty issue is more than just column, it also wants the "cursor" output that compilers include. I'll file a separate issue about that.

[lilyball]

Filed as #2268 (though the lack of a column is also important here).

[jpsim]

I wonder if there would be any negative ramifications of using a fallback column of 1 if there's none provided. This would be very easy to do.

[lilyball]

Probably very minimal. You could also use a column of 0 to signify that there is no column information (similar to how Swift backtraces use a line number of 0 for generated code that has no associated source line).

[jpsim]

Went with a fallback column value of 1 like we do for line numbers. At least this way the location is a valid location in the file. Seems safer. #2488

[jpsim]

Addressed in #2488.