Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow Bundle() or Device() inits as they can be harmful #1306

Closed
Noobish1 opened this issue Feb 14, 2017 · 2 comments
Closed

Don't allow Bundle() or Device() inits as they can be harmful #1306

Noobish1 opened this issue Feb 14, 2017 · 2 comments
Labels
rule-request Requests for a new rules.

Comments

@Noobish1
Copy link

We ran into a couple of these recently and we wrote some custom rules to make sure we never have them in our codebase ever again. Not sure if it's worth having a rule for, just figured i'd see what everyone thought.
@jpsim jpsim added the rule-request Requests for a new rules. label Feb 15, 2017
@jpsim
Copy link
Collaborator

jpsim commented Feb 15, 2017

Seems reasonable to me.

ornithocoder added a commit to ornithocoder/personal-fork-swiftlint that referenced this issue Aug 1, 2017
@ornithocoder
Add discouraged_init opt-in rule
8c6a5da 
Rule requested by @Noobish1 on issue realm#1306.
@ornithocoder ornithocoder mentioned this issue Aug 1, 2017
Merged
ornithocoder added a commit to ornithocoder/personal-fork-swiftlint that referenced this issue Aug 1, 2017
@ornithocoder
Add discouraged_init opt-in rule
901b627 
Rule requested by @Noobish1 on issue realm#1306.
ornithocoder added a commit to ornithocoder/personal-fork-swiftlint that referenced this issue Aug 1, 2017
@ornithocoder
Add discouraged_direct_init opt-in rule
13c7e6e 
Rule requested by @Noobish1 on issue realm#1306.
@ornithocoder
Copy link
Contributor

@jpsim @marcelofabri issue can be closed :-)

@jpsim jpsim closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Noobish1 @jpsim @ornithocoder