Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak CI config #1314

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Unbreak CI config #1314

merged 6 commits into from
Aug 17, 2022

Conversation

agjohnson
Copy link
Collaborator

Build with Node 14 installed through orbs.

Fixes #1275

@agjohnson
Fix CircleCI config
34e29e6 
Build with Node 14 installed through orbs.

Fixes #1275
@agjohnson agjohnson requested a review from a team as a code owner August 17, 2022 18:31
@agjohnson
Copy link
Collaborator Author

agjohnson commented Aug 17, 2022 •
edited
Loading

Error is unrelated, and was brought in with bc73ad8. Build failure is:

ERROR in ./src/sass/theme.sass
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):

  :not(kbd) > kbd,
 ^
      Property "not" must be followed by a ':'

I won't fix that in this PR.

@agjohnson
Fix SASS syntax errors from #967
2dbaef8 
This introduced syntax errors that were not picked up in review, the
`:not()` psuedo selector can't lead a selector in SASS.
@agjohnson agjohnson mentioned this pull request Aug 17, 2022
Merged
This was referenced Aug 17, 2022
Closed
Closed
benjaoming
benjaoming approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benjaoming benjaoming merged commit 4efbdbc into master Aug 17, 2022
@benjaoming benjaoming deleted the agj/fix-ci branch August 17, 2022 22:57
@benjaoming benjaoming mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaoming benjaoming benjaoming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is failing
2 participants
@agjohnson @benjaoming