Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when resolving wilcard imports #156

Closed
AWhetter opened this issue Nov 20, 2018 · 2 comments
Closed

Error when resolving wilcard imports #156

AWhetter opened this issue Nov 20, 2018 · 2 comments

Comments

@AWhetter
Copy link
Collaborator

When a package imports from itself using a wildcard import, the extension tries to find an object with a '*' in its name. It can't so it fails with a KeyError.
Instead, we'll have to add a special case where wildcard imports instead create new placeholders under that module for everything that gets imported.

@mangopipeline
Copy link

Damn...
Well I just spent the last few hours refactoring a large code base.

I have no wild card import anywhere...

And the issue did not go away :(

@mangopipeline
Copy link

Could it be that relative imports are breaking it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants