Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules: user message when there are problems cloning them #9365

Open
humitos opened this issue Jun 22, 2022 · 1 comment
Open

Submodules: user message when there are problems cloning them #9365

humitos opened this issue Jun 22, 2022 · 1 comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Jun 22, 2022

I thought we had an issue opened for this, but I wasn't able to find it.

The problem that I've seen is that if the project is using submodules.include: all and there is at least one submodule that fails to clone for any reason the build fails with the generic message without communicating the users what's the problem.

The solution that I've told the users is to just find out what's that submodule and remove it from .gitmodules. It would be good if we could detect this scenario and tell the users

  • what's the exact module that it's not working so they can remove it
  • there is a submodule that will be skipped because it failed to clone

I wanted to create a test-builds branch to reproduce this case, but I'm not exactly how to create it.

@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jun 22, 2022
@agjohnson
Copy link
Contributor

I'll roll #9539 into this issue, they are related. We should throw an error for both of these cases. The error in #9539 is fairly bad UX, but shouldn't be super common -- it only affects projects that had a submodule that was partially removed.

@humitos humitos changed the title Submodules: user message when there are problems clonning them Submodules: user message when there are problems cloning them Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
Status: Planned
Development

No branches or pull requests

2 participants