Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another issue about submodules #4865

Closed
bluecmd opened this issue Nov 5, 2018 · 8 comments
Closed

Yet another issue about submodules #4865

bluecmd opened this issue Nov 5, 2018 · 8 comments
Labels
Support Support question

Comments

@bluecmd
Copy link

bluecmd commented Nov 5, 2018

Hi,

Project: u-bmc
Error: https://readthedocs.org/projects/u-bmc/builds/8054931/

u-bmc uses submodules quite heavily and contains a lot of data. There is no earthly reason for readthedocs to check that out and I'd like to disable it.

I found some PRs and some other issues that talks about how this is possible, but I did not see any documentation about how to enable it for my own repo. Am I correct in assuming that:

  1. There is a secret internal tag you set on projects for now to disable submodules?
  2. There will be support in the upcoming v2 configuration, but there is not in the current v1?

If so, could I ask for the secret flag on u-bmc?
Thanks!

@stsewd
Copy link
Member

stsewd commented Nov 5, 2018

both, 1 and 2 are true. but I think there is something else causing the error, I'll investigate now

@stsewd stsewd added the Support Support question label Nov 5, 2018
@bluecmd
Copy link
Author

bluecmd commented Nov 5, 2018

Sure thing! The build time has the suspicious number of 899 seconds, and I read you have a 900 seconds timeout, so if you start a betting pool you know where my bet is ;-).

@stsewd
Copy link
Member

stsewd commented Nov 5, 2018

So, yeah, it's failing on git submodule update --init --force --recursive u-boot linux

@bluecmd
Copy link
Author

bluecmd commented Nov 6, 2018

Hi again,

Just making sure this didn't fall between the metaphorical chairs. @stsewd , what's the next steps here?

@stsewd
Copy link
Member

stsewd commented Nov 6, 2018

Sorry, I almost forgot, not sure what to do here, but I'll ask the team. Some possibilities could be:

  • Wait to release config v2 (probably not the best solution because of the time)
  • Set a flag to use the alfa version of v2 (which include submodules settings, but the schema is open to changes, so you'll need to change that on the final release, and we don't have deployed docs)
  • Set the current magical flag (we are trying to not abuse of this because v2 is coming soon)

@agjohnson
Copy link
Contributor

👍 on just setting the feature flag for now, if you don't need any of the submodules for the project.

@bluecmd
Copy link
Author

bluecmd commented Nov 10, 2018

Sgtm! The submodules are just for building.

@humitos
Copy link
Member

humitos commented Nov 12, 2018

@bluecmd I added the flag to skip submodules checkout to your project.

I'm closing this issue here, but feel free to reopen if it doesn't work as you expected or give us feedback/update ;)

Thanks!

@humitos humitos closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

4 participants