Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtd ist not following language code update for Chinese #4411

Open
Flohack74 opened this issue Jul 20, 2018 · 5 comments
Open

rtd ist not following language code update for Chinese #4411

Flohack74 opened this issue Jul 20, 2018 · 5 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@Flohack74
Copy link

Details

  • Try to configure Chinese traditional and simplified languages

Expected Result

  • The selection should be zh_Hans and zh_Hant

Actual Result

  • Selection is zh_CN and zh_TW

See https://code.djangoproject.com/ticket/18419 for example. zh_CN is no longer common sense, and we got issues with linking our Weblate to rtd, since Weblate does not support zh_CN anymore.

@RichardLitt
Copy link
Member

@Flohack74 Can this be closed, now?

@Flohack74
Copy link
Author

Not really. We reverted our patch because otherwise we could no longer feed transtlations into readthedocs I assume. It seems that at a certain point Django was switched to the new codes, and new language po files fill always be named like that.

Please evaluate the situation here, maybe allowing support for both naming schemes.

@humitos
Copy link
Member

humitos commented Jul 23, 2018

I suppose we should check some things here:

  • our current translations under transifex
  • this change is supported by Sphinx
  • old URLs that point to zn_CN

@agjohnson agjohnson added this to the I18n improvements milestone Aug 3, 2018
@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap and removed Improvement Minor improvement to code labels Aug 3, 2018
@agjohnson
Copy link
Contributor

Sounds like we need to update our language selector to add the new identifiers for chinese lanuages? We can leave the old identifiers probably? Optionally, we can hide the deprecated identifier for new projects.

Sphinx should be agnostic to this.

I imagine a PR should be fairly quick to put together for this.

@Flohack74
Copy link
Author

Yeah I think thats the best way, stay compatible with whats there, but try to offer only the new shortcuts for new stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

5 participants