Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allauth: require re-authentication for some actions #11345

Open
stsewd opened this issue May 22, 2024 · 2 comments
Open

allauth: require re-authentication for some actions #11345

stsewd opened this issue May 22, 2024 · 2 comments
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented May 22, 2024

What's the problem this feature will solve?

Allauth has some cool feature that asks the user to re-authenticate when doing some operations, like changing email etc, this improves security for some actions that may be dangerous.

Describe the solution you'd like

Set ACCOUNT_REAUTHENTICATION_REQUIRED to true, and use the reauthentication_required on some views that are important, like adding owners or deleting a project.

@stsewd stsewd added Improvement Minor improvement to code Needed: design decision A core team decision is required labels May 22, 2024
@humitos
Copy link
Member

humitos commented Jun 17, 2024

I found this issue related to https://github.com/readthedocs/readthedocs-corporate/issues/969, that talks about requiring a verified email to perform some actions.

@ericholscher
Copy link
Member

I notice that Stripe does this sometimes, and it makes sense. I'd probably set ACCOUNT_REAUTHENTICATION_TIMEOUT to something like ~30 minutes, so folks can perform a few admin actions without getting multiple login prompts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants