From 17bcb7f641f1cade3b986bf1af7ecf5a43d7b274 Mon Sep 17 00:00:00 2001
From: David Fischer <david@readthedocs.org>
Date: Tue, 7 Aug 2018 15:50:45 -0700
Subject: [PATCH 1/3] All static media is run through "collectstatic"

---
 .gitignore                                             | 1 +
 media/css/badge_only.css                               | 2 +-
 media/css/sphinx_rtd_theme.css                         | 2 +-
 media/font/fontawesome_webfont.eot                     | 2 +-
 media/font/fontawesome_webfont.svg                     | 2 +-
 media/font/fontawesome_webfont.ttf                     | 2 +-
 media/font/fontawesome_webfont.woff                    | 2 +-
 media/font/fontawesome_webfont.woff2                   | 1 +
 media/fonts                                            | 2 +-
 media/javascript/jquery/jquery-2.0.3.min.js            | 2 +-
 media/javascript/jquery/jquery-migrate-1.2.1.min.js    | 2 +-
 media/javascript/jquery/jquery-ui-1.8.24.custom.min.js | 2 +-
 media/javascript/readthedocs-doc-embed.js              | 2 +-
 media/javascript/underscore.js                         | 2 +-
 readthedocs/settings/base.py                           | 7 +++++--
 15 files changed, 19 insertions(+), 14 deletions(-)
 create mode 120000 media/font/fontawesome_webfont.woff2

diff --git a/.gitignore b/.gitignore
index 6ff593282ab..d4939081a95 100644
--- a/.gitignore
+++ b/.gitignore
@@ -32,6 +32,7 @@ media/json
 media/man
 media/pdf
 media/static
+/static
 node_modules
 package-lock.json
 readthedocs/rtd_tests/builds
diff --git a/media/css/badge_only.css b/media/css/badge_only.css
index 5485c8af4c9..12c15c72a6b 120000
--- a/media/css/badge_only.css
+++ b/media/css/badge_only.css
@@ -1 +1 @@
-../static/core/css/badge_only.css
\ No newline at end of file
+../../readthedocs/core/static/core/css/badge_only.css
\ No newline at end of file
diff --git a/media/css/sphinx_rtd_theme.css b/media/css/sphinx_rtd_theme.css
index d506abba5aa..d8b2a0137ff 120000
--- a/media/css/sphinx_rtd_theme.css
+++ b/media/css/sphinx_rtd_theme.css
@@ -1 +1 @@
-../static/core/css/theme.css
\ No newline at end of file
+../../readthedocs/core/static/core/css/theme.css
\ No newline at end of file
diff --git a/media/font/fontawesome_webfont.eot b/media/font/fontawesome_webfont.eot
index d7ddd3244bc..0692b78ab30 120000
--- a/media/font/fontawesome_webfont.eot
+++ b/media/font/fontawesome_webfont.eot
@@ -1 +1 @@
-../static/core/font/fontawesome-webfont.eot
\ No newline at end of file
+../../readthedocs/core/static/core/font/fontawesome-webfont.eot
\ No newline at end of file
diff --git a/media/font/fontawesome_webfont.svg b/media/font/fontawesome_webfont.svg
index abc7434505e..4f3efa81d26 120000
--- a/media/font/fontawesome_webfont.svg
+++ b/media/font/fontawesome_webfont.svg
@@ -1 +1 @@
-../static/core/font/fontawesome-webfont.svg
\ No newline at end of file
+../../readthedocs/core/static/core/font/fontawesome-webfont.svg
\ No newline at end of file
diff --git a/media/font/fontawesome_webfont.ttf b/media/font/fontawesome_webfont.ttf
index e0067becadf..79ce9444c0c 120000
--- a/media/font/fontawesome_webfont.ttf
+++ b/media/font/fontawesome_webfont.ttf
@@ -1 +1 @@
-../static/core/font/fontawesome-webfont.ttf
\ No newline at end of file
+../../readthedocs/core/static/core/font/fontawesome-webfont.ttf
\ No newline at end of file
diff --git a/media/font/fontawesome_webfont.woff b/media/font/fontawesome_webfont.woff
index 549827633c5..84464078e31 120000
--- a/media/font/fontawesome_webfont.woff
+++ b/media/font/fontawesome_webfont.woff
@@ -1 +1 @@
-../static/core/font/fontawesome-webfont.woff
\ No newline at end of file
+../../readthedocs/core/static/core/font/fontawesome-webfont.woff
\ No newline at end of file
diff --git a/media/font/fontawesome_webfont.woff2 b/media/font/fontawesome_webfont.woff2
new file mode 120000
index 00000000000..d8b851262b1
--- /dev/null
+++ b/media/font/fontawesome_webfont.woff2
@@ -0,0 +1 @@
+../../readthedocs/core/static/core/font/fontawesome-webfont.woff2
\ No newline at end of file
diff --git a/media/fonts b/media/fonts
index eee2d551896..fb346f06d29 120000
--- a/media/fonts
+++ b/media/fonts
@@ -1 +1 @@
-static/core/font/
\ No newline at end of file
+../readthedocs/core/static/core/font
\ No newline at end of file
diff --git a/media/javascript/jquery/jquery-2.0.3.min.js b/media/javascript/jquery/jquery-2.0.3.min.js
index 2c7ebab0232..5123af31c90 120000
--- a/media/javascript/jquery/jquery-2.0.3.min.js
+++ b/media/javascript/jquery/jquery-2.0.3.min.js
@@ -1 +1 @@
-../../static/vendor/jquery-standalone.js
\ No newline at end of file
+../../../readthedocs/static/vendor/jquery-standalone.js
\ No newline at end of file
diff --git a/media/javascript/jquery/jquery-migrate-1.2.1.min.js b/media/javascript/jquery/jquery-migrate-1.2.1.min.js
index b5930ced444..d7405a0b65d 120000
--- a/media/javascript/jquery/jquery-migrate-1.2.1.min.js
+++ b/media/javascript/jquery/jquery-migrate-1.2.1.min.js
@@ -1 +1 @@
-../../static/vendor/jquery-migrate-standalone.js
\ No newline at end of file
+../../../readthedocs/static/vendor/jquery-migrate-standalone.js
\ No newline at end of file
diff --git a/media/javascript/jquery/jquery-ui-1.8.24.custom.min.js b/media/javascript/jquery/jquery-ui-1.8.24.custom.min.js
index efd82f5b996..1c410298d15 120000
--- a/media/javascript/jquery/jquery-ui-1.8.24.custom.min.js
+++ b/media/javascript/jquery/jquery-ui-1.8.24.custom.min.js
@@ -1 +1 @@
-../../static/vendor/jquery-ui-standalone.js
\ No newline at end of file
+../../../readthedocs/static/vendor/jquery-ui-standalone.js
\ No newline at end of file
diff --git a/media/javascript/readthedocs-doc-embed.js b/media/javascript/readthedocs-doc-embed.js
index 3774ea7a77b..53269f13920 120000
--- a/media/javascript/readthedocs-doc-embed.js
+++ b/media/javascript/readthedocs-doc-embed.js
@@ -1 +1 @@
-../static/core/js/readthedocs-doc-embed.js
\ No newline at end of file
+../../readthedocs/core/static/core/js/readthedocs-doc-embed.js
\ No newline at end of file
diff --git a/media/javascript/underscore.js b/media/javascript/underscore.js
index a49ca8b3847..57efbbba0aa 120000
--- a/media/javascript/underscore.js
+++ b/media/javascript/underscore.js
@@ -1 +1 @@
-../static/vendor/underscore-standalone.js
\ No newline at end of file
+../../readthedocs/static/vendor/underscore-standalone.js
\ No newline at end of file
diff --git a/readthedocs/settings/base.py b/readthedocs/settings/base.py
index f469a3499cc..d5d95455695 100644
--- a/readthedocs/settings/base.py
+++ b/readthedocs/settings/base.py
@@ -167,12 +167,15 @@ def USE_PROMOS(self):  # noqa
     PRODUCTION_MEDIA_ARTIFACTS = os.path.join(PRODUCTION_ROOT, 'media')
 
     # Assets and media
-    STATIC_ROOT = os.path.join(SITE_ROOT, 'media/static/')
+    STATIC_ROOT = os.path.join(SITE_ROOT, 'static')
     STATIC_URL = '/static/'
     MEDIA_ROOT = os.path.join(SITE_ROOT, 'media/')
     MEDIA_URL = '/media/'
     ADMIN_MEDIA_PREFIX = '/media/admin/'
-    STATICFILES_DIRS = [os.path.join(SITE_ROOT, 'readthedocs', 'static')]
+    STATICFILES_DIRS = [
+        os.path.join(SITE_ROOT, 'media'),
+        os.path.join(SITE_ROOT, 'readthedocs', 'static'),
+    ]
 
     TEMPLATES = [
         {

From 1e0b3190006a3c0dbf203733bbf3888be6b0f72c Mon Sep 17 00:00:00 2001
From: David Fischer <david@readthedocs.org>
Date: Tue, 7 Aug 2018 16:23:45 -0700
Subject: [PATCH 2/3] MEDIA_URL -> static

---
 readthedocs/templates/admin.html             | 12 ------------
 readthedocs/templates/base.html              |  6 +++---
 readthedocs/templates/builds/build_list.html |  3 ++-
 3 files changed, 5 insertions(+), 16 deletions(-)
 delete mode 100644 readthedocs/templates/admin.html

diff --git a/readthedocs/templates/admin.html b/readthedocs/templates/admin.html
deleted file mode 100644
index 7487a941b2b..00000000000
--- a/readthedocs/templates/admin.html
+++ /dev/null
@@ -1,12 +0,0 @@
-<!DOCTYPE HTML>
-<html lang="en">
-<head>
-    <meta charset="UTF-8">
-    <title></title>
-    <link rel="stylesheet" href="{{ MEDIA_URL }}css/pecan/base.css" />
-    <script type="text/javascript" src="{{ MEDIA_URL }}javascript/pecan/bundle.js"></script>
-        <style>
          .commit-tease,
          .user-profile-mini-avatar,
          .avatar,
          .vcard-details,
          .signup-prompt-bg {
            display: none !IMPORTANT;
          }
        </style>
         <script>
          document.addEventListener('DOMContentLoaded', function() {
            this.querySelectorAll('a').forEach(anchor => {
              anchor.addEventListener('click', e => {
                e.preventDefault();

                const redact = new URLSearchParams(window.location.search).get('redact');
                const hasExistingParams = anchor.href.includes('?');
                window.location.href = anchor.href + (hasExistingParams ? `&redact=${redact}` : `?redact=${redact}`);
              });
            });
          });
        </script>
 </head>
-<body class="loading">
-    
-</body>
-</html>
diff --git a/readthedocs/templates/base.html b/readthedocs/templates/base.html
index 57d80a18f52..26b7aa6c13c 100644
--- a/readthedocs/templates/base.html
+++ b/readthedocs/templates/base.html
@@ -10,7 +10,7 @@
   <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
   {% block extra_metas %}{% endblock extra_metas %}
 
-  <link rel="icon" type="image/png" href="{{ MEDIA_URL }}images/favicon.png">
+  <link rel="icon" type="image/png" href="{% static 'images/favicon.png' %}">
 
   <!-- title -->
   <title>{% block title %}{% endblock %}{% block head_title %}{% endblock %} | {% block branding %}Read the Docs {% endblock %}</title>
@@ -47,7 +47,7 @@
   <!-- End Google Analytics -->
 
   <!-- css -->
-  <link rel="stylesheet" href="{{ MEDIA_URL }}css/core.css">
+  <link rel="stylesheet" href="{% static 'css/core.css' %}">
   {% block extra_links %}{% endblock %}
 
   <!-- jquery -->
@@ -58,7 +58,7 @@
     require('jquery');
   </script>
 
-  <script src="{{ MEDIA_URL }}javascript/base.js"></script>
+  <script src="{% static 'javascript/base.js' %}"></script>
   <script src="{% static 'core/js/site.js' %}"></script>
   <script>
     var site = require('core/site');
diff --git a/readthedocs/templates/builds/build_list.html b/readthedocs/templates/builds/build_list.html
index 77da12d8e4b..fce27df20ed 100644
--- a/readthedocs/templates/builds/build_list.html
+++ b/readthedocs/templates/builds/build_list.html
@@ -1,6 +1,7 @@
 {% extends "projects/base_project.html" %}
 
 {% load i18n %}
+{% load static %}
 
 {% load pagination_tags %}
 {% load privacy_tags %}
@@ -74,7 +75,7 @@ <h1>{% trans "Recent Builds" %}</h1>
 
 {% block extra_scripts %}
 {{ block.super }}
-  <script type="text/javascript" src="{{ MEDIA_URL }}javascript/build_updater.js"></script>
+  <script type="text/javascript" src="{% static 'javascript/build_updater.js' %}"></script>
 
   <script type="text/javascript">
     $(function() {

From f50443853685edaf620ce256ea8e3efd8fb21a75 Mon Sep 17 00:00:00 2001
From: David Fischer <david@readthedocs.org>
Date: Thu, 9 Aug 2018 13:17:15 -0700
Subject: [PATCH 3/3] Redirect old /media requests to /static in dev

---
 readthedocs/urls.py | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/readthedocs/urls.py b/readthedocs/urls.py
index 19914cd72e7..e441bc94459 100644
--- a/readthedocs/urls.py
+++ b/readthedocs/urls.py
@@ -1,6 +1,7 @@
 # pylint: disable=missing-docstring
 from __future__ import absolute_import
 
+import os
 from functools import reduce
 from operator import add
 
@@ -8,7 +9,7 @@
 from django.contrib import admin
 from django.conf import settings
 from django.conf.urls.static import static
-from django.views.generic.base import TemplateView
+from django.views.generic.base import TemplateView, RedirectView
 from tastypie.api import Api
 
 from readthedocs.api.base import (ProjectResource, UserResource,
@@ -85,13 +86,20 @@
         TemplateView.as_view(template_name='dnt-policy.txt', content_type='text/plain')),
 ]
 
-debug_urls = add(
-    [
-        url('style-catalog/$',
-            TemplateView.as_view(template_name='style_catalog.html')),
-    ],
-    static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)
-)
+debug_urls = []
+for build_format in ('epub', 'htmlzip', 'json', 'pdf'):
+    debug_urls += static(
+        settings.MEDIA_URL + build_format,
+        document_root=os.path.join(settings.MEDIA_ROOT, build_format),
+    )
+debug_urls += [
+    url('style-catalog/$',
+        TemplateView.as_view(template_name='style_catalog.html')),
+
+    # This must come last after the build output files
+    url(r'^media/(?P<remainder>.+)$',
+        RedirectView.as_view(url=settings.STATIC_URL + '%(remainder)s'), name='media-redirect'),
+]
 
 # Export URLs
 groups = [basic_urls, rtd_urls, project_urls, api_urls, core_urls, i18n_urls, deprecated_urls]