Skip to content

Remove PR build warning #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove PR build warning #583

wants to merge 1 commit into from

Conversation

ericholscher
Copy link
Member

The Files Changed UI solves this problem in a much nicer way.
I think we can get rid of this warning,
since it's just in the way now.

The Files Changed UI solves this problem in a much nicer way.
I think we can get rid of this warning,
since it's just in the way now.
@ericholscher ericholscher requested review from humitos and a team as code owners May 20, 2025 12:43
@ericholscher ericholscher requested a review from agjohnson May 20, 2025 12:43
@ericholscher
Copy link
Member Author

Ping :)

@humitos
Copy link
Member

humitos commented Jun 2, 2025

We discussed this already in a few other issues/PRs and there are still valid points to not remove it, IMO:

  • We still have the option show_on_external in the settings page
  • People with that option marked will loose this notification
  • The visual diff bar does not communicates the documentation set is from a PR and it's not live (we know that, but users may not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants