Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Checkboxes are currently not being rendered in non-admin view when sanitise comment is on (in all legacy, mdx, mdxish projects). The root cause of this is because of the
remarkParseandremarkStringifyplugins in the stripComments pipeline which escapes [ ].The fix is to utilise the micromark plugin
mdast-util-gfm-task-list-itemthat specifically parses checkboxes correctly in the pipeline. This should be safe to do as it's just an extension of the pipeline. The reasons of why this is not an issue in mdx or mdxish is because it usesremark-gfmwhich already included that plugin.🧬 QA & Testing