Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong position after rotation #344

Closed
RomanSoviak opened this issue Oct 20, 2023 · 5 comments · Fixed by #347
Closed

Wrong position after rotation #344

RomanSoviak opened this issue Oct 20, 2023 · 5 comments · Fixed by #347
Labels
bug Something isn't working

Comments

@RomanSoviak
Copy link

RPReplay_Final1697358920.1.MP4
RPReplay_Final1697646785.MP4
@RomanSoviak
Copy link
Author

hi @mickael-menu, as you recommended in Slack I provide more details/steps for reproducing this bug:

  1. I downloaded the app from here: https://testflight.apple.com/join/lYEMEfBr
  2. Opened OPDS catalogue and fetched the first book
    image
  3. Then I went to the library and opened book.
    After some rotations position was shifted to the start of the chapter: https://github.com/readium/swift-toolkit/assets/26696190/4ce9d407-ece5-4250-8994-27d6616bd7ed
  4. This bug was reported by our user on the tablet.
    https://github.com/readium/swift-toolkit/assets/26696190/fb681c19-5779-4628-b039-38f320b912c3
    This book has one big chapter and it's uncomfortable when position changed from 57/281 to the 1/281. Could you please help with that. Should we store locator somewhere and after this rotations use it? Or what should we do in cases like that?
    Thanks in advance🙂

@mickael-menu
Copy link
Member

There are two different issues:

  1. When you rotate several times the screen, the position is progressively moving backwards. This is expected and a current limitation of the toolkit, because we restore the web view progression instead of an exact location in the HTML resource. This should not be an issue for your users though.
  2. If you rotate the screen two times too fast (before the chapter has the opportunity of rendering), then we loose the current location and end up at the beginning of the current chapter. This is a bug that needs to be fixed in Readium, there's nothing to do in your app.

@mickael-menu
Copy link
Member

@RomanSoviak Could you check that this PR solves the problem for you? #347

@RomanSoviak
Copy link
Author

It works!
Thanks a lot!
Do you plan to release a new version with that update?
@mickael-menu

@mickael-menu
Copy link
Member

Yes I'll do a patch release after this other PR is solved: #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants