-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue building with Carthage on Xcode 12 #1
Comments
This is fixed in Carthage 0.37, by using
|
Unfortunately it fails with:
It looks like it's just a matter of upgrading Fuzi to 3.1.3. Until then, the previous script still work. |
I can build sucessfully with |
I have successfully built the latest develop branch project with xcode version |
Xcode 12 chronicles, part II 😓 As stated in this issue, since Xcode 12 we must build XCFrameworks with Carthage. Unfortunately, Carthage failed if we were still linking to regular frameworks in R2 modules (let's call it the 🍌 issue). The solution was to switch to XCFrameworks for every nested dependencies. However, a XCFramework is resolved with a path relative to the local project, while a regular Somehow, Xcode 12 didn't mind until 12.5, which now complains with the following errors (only when integrating R2 as git submodules): The solution seems to revert back to linking to regular Until then, a workaround is to make sure that the |
@mickael-menu That saved me hours of research as to what's going on. I was running into the same issue. Thanks for posting. |
Carthage 0.38.0 is out:
@aferditamuriqi They also wrote something that might be interesting for R2LCPClient:
|
I reverted back to using the
See readium/r2-shared-swift#153 That means that using Readium as Git submodules with Carthage is not possible anymore with Xcode 12.5+. If you were doing this, you can either:
@alexwhb Let me know if you have an issue with this. |
@mickael-menu This is actually fantastic news. I'm using SwiftPM in most of my project other than a few modules including this one that, up till now, did not have a way to use them with SwiftPM. I'll give it a try soon. 👍 Thanks for letting me know. |
…oading-time Improved epub loading performance
Disable user select text in epub
UPDATE: This has been fixed in Carthage, which can now build with Xcode 12 using:
However, you need to make sure that you use the latest version of Readium, from the
develop
branch.There's currently an issue with Xcode 12 when trying to build Carthage dependencies. Unfortunately, it's not something we can address in Readium.
If you don't want to stick with Xcode 11, a workaround until Carthage is fixed is to use the following script instead of the regular Carthage command:
Add it to
/usr/local/bin
,chmod a+x carthage.sh
and then you can use it like that:carthage.sh update --platform ios
.The text was updated successfully, but these errors were encountered: