Init VoiceManager #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New data script, Voice manager Class, switch to built for testing (per TS-recipe recommandation)
there is some mapping to do as data is not using the same codes
Exclude novelty and lowQuality by default when getting voices
Contributor
Author
|
Marking as ready review as I’m assuming data migration will be done through another PR after we discuss it next week. @panaC @danielweck who’s up for a review? This replaces voices helpers with a new WebSpeechVoiceManager class that is using an interface mapped to the original data so definitely breaking in various ways 😬 |
Unlikely to be ever used.
Then again ava doesn’t nest so… this is flat and results print as they come
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates previous “Voices” code with playback, by creating a
WebSpeechVoiceManagerthat provides with the grouping, filtering, and sorting options that were previously available.The manager is a singleton that has to be initialised asynchronously, two demos demonstrate how you can then use its methods to filter, sort, etc.
It is still a draft as we will migrate data to this repository instead of generating it from another place, with actions in place to validate the json schema. This is also why the
IVoices, nowReadiumSpeechVoices, use the schema directly.