Fix crash when opening a PDF, when the ResourceDataProvider is not used while initializing

mickael-menu · mickael-menu · commit b68a60f9fd45 · 2024-04-04T14:14:48.000+02:00
diff --git a/readium/adapters/pspdfkit/document/src/main/java/org/readium/adapter/pspdfkit/document/PsPdfKitDocument.kt b/readium/adapters/pspdfkit/document/src/main/java/org/readium/adapter/pspdfkit/document/PsPdfKitDocument.kt
@@ -47,7 +47,9 @@ public class PsPdfKitDocumentFactory(context: Context) : PdfDocumentFactory<PsPd
             } catch (e: InvalidSignatureException) {
                 Try.failure(ReadError.Decoding(ThrowableError(e)))
             } catch (e: IOException) {
-                Try.failure(dataProvider.error!!)
+                Try.failure(dataProvider.error
+                    ?: ReadError.UnsupportedOperation(ThrowableError(IllegalStateException(e)))
+                )
             }
         }
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,9 @@ public class PsPdfKitDocumentFactory(context: Context) : PdfDocumentFactory<PsPd`
`47`	`47`	`} catch (e: InvalidSignatureException) {`
`48`	`48`	`Try.failure(ReadError.Decoding(ThrowableError(e)))`
`49`	`49`	`} catch (e: IOException) {`
`50`		`- Try.failure(dataProvider.error!!)`
	`50`	`+ Try.failure(dataProvider.error`
	`51`	`+ ?: ReadError.UnsupportedOperation(ThrowableError(IllegalStateException(e)))`
	`52`	`+ )`
`51`	`53`	`}`
`52`	`54`	`}`
`53`	`55`	`}`