Fix handling EPUB noteref with nested elements (#503)

mickael-menu · web-flow · commit 3abdb8ceb05b · 2024-04-29T13:51:27.000+02:00
diff --git a/readium/navigator/src/main/java/org/readium/r2/navigator/R2BasicWebView.kt b/readium/navigator/src/main/java/org/readium/r2/navigator/R2BasicWebView.kt
@@ -287,7 +287,7 @@ internal open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebV
         // We ignore taps on interactive element, unless it's an element we handle ourselves such as
         // pop-up footnotes.
         if (event.interactiveElement != null) {
-            return handleFootnote(event.targetElement)
+            return handleFootnote(event.interactiveElement)
         }
 
         return runBlocking(uiScope.coroutineContext) { listener?.onTap(event.point) ?: false }

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ internal open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebV`
`287`	`287`	`// We ignore taps on interactive element, unless it's an element we handle ourselves such as`
`288`	`288`	`// pop-up footnotes.`
`289`	`289`	`if (event.interactiveElement != null) {`
`290`		`- return handleFootnote(event.targetElement)`
	`290`	`+ return handleFootnote(event.interactiveElement)`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`return runBlocking(uiScope.coroutineContext) { listener?.onTap(event.point) ?: false }`